Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AS9716-32D] Modify thermal code to python3 #9969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jostar-yang
Copy link
Contributor

Signed-off-by: Jostar Yang jostar_yang@accton.com.tw

Why I did it

  1. Modify thermal code from python2 to python3
  2. Fix thermal code bug

How I did it

  1. Remove py2 code and use py3 api or format
  2. Fix thermal bug

How to verify it

Test accton_as9716_32d_monitor.py and there is no error. And it can read fan and thermal sysfs.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
@jostar-yang
Copy link
Contributor Author

Add test information.
Add state=MAX when fan is plugged out.
Plug out one fan , other fan speed will change to 100%.
But plug in the fan back , all fan speed still are 100%.

  • How to verify it
    Run thermal plan service, plug out fan-6.
    Check fan speed=100%. Insert back fan-6, and check fan speed should according to thermal plan.

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request fixes 4 alerts when merging 8c92bdb into b621daf - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant